fix/ESO upgrade#123
Open
day0hero wants to merge 13 commits into
Open
Conversation
Contributor
day0hero
commented
Apr 17, 2026
day0hero
commented
- Repo/ESO Updates
- update to values-group-one.yaml
Collaborator
day0hero
force-pushed
the
fix/ESO_upgrade
branch
from
d16f662 to
78350b0
Compare
mlorenzofr
requested changes
Apr 24, 2026
day0hero
added a commit
to day0hero/layered-zero-trust
that referenced
this pull request
Apr 27, 2026
- in response to validatedpatterns#123 - where we need to figure out better long term approaches for modernizing the repo structure. - this commit modifies just the values-hub.yaml and the ESO manifests within the repository to use openshift-external-secrets-operator
- ran patternizer against the repo to ensure that the latest goodness is
from the vp framework is applied.
- updated ESO from upstream to openshift supported
- updated values-hub to use `argoProject{,s}`
- changed namespace definition from list to dictionary. this is
currently required for the framework to support multiple versions of
an operator/service (golang-external-secrets/openshift-external-secrets)
- changed job behavior to match rhtpa-ingress-ca-extractor chart - central-htpasswd is now operator-managed
mlorenzofr
requested changes
Jun 4, 2026
Collaborator
mlorenzofr
left a comment
mlorenzofr
left a comment
There was a problem hiding this comment.
we need to correct the conflicts in the values-hub.yaml file (remove the policies and jwt configuration blocks) and add an new policy
added policy Co-authored-by: Manuel Lorenzo <mlorenzofr@gmail.com>
Contributor
Author
|
@mlorenzofr - everything should be resolved now. please confirm |
mlorenzofr
approved these changes
Jun 5, 2026
Collaborator
mlorenzofr
left a comment
mlorenzofr
left a comment
There was a problem hiding this comment.
The changes are working well, but we need other changes to complete the transition.
- Merge validatedpatterns/rhbk-chart#7 so that the RHBK chart uses the correct API version in the
ExternalSecrets - Make a small refactor in
scripts/gen-feature-variants.pyto address some changes related to data types and the location of JWT roles. I'll do this in another PR, I almost have the changes ready.
sabre1041
requested changes
Jun 5, 2026
Collaborator
sabre1041
left a comment
sabre1041
left a comment
There was a problem hiding this comment.
Encountered a few issues during testing.
- See comments for issues with array values
- Needed to specify the variable
TARGET_ORIGIN=originwhen running./pattern.sh make install - Once the pattern has been deployed, verification of the Argo CD apps is occurring. There are use cases within the pattern for which Argo CD apps would not fully synchronize until certain conditions are met. Would it be possible to restore not validating the Argo CD Apps?
Collaborator
There was a problem hiding this comment.
Had to update to the following on my OSX based machine. Otherwise an error was produced because the array was unbound
${PKI_HOST_MOUNT_ARGS[@]+"${PKI_HOST_MOUNT_ARGS[@]}"} \
same with the EXTRA_ARGS_ARRAY[@] a bit further down
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.